Misc TypeScript Migrations

[WilliamWelsh]

I wanted to help with the TypeScript rollout, so I've migrated the following so far:

src/data

• src/data/addresses.js
• src/data/eth-upgrade-articles.js

src/api

• src/api/etherscanBlock.js
• src/api/etherscan.js
• src/api/l2beat.js
• src/api/roadmap.js
• src/api/translations.js
• src/api/txs.js

src/lambda

• src/lambda/etherscanBlock.js
• src/lambda/etherscan.js
• src/lambda/l2beat.js
• src/lambda/roadmap.js
• src/lambda/translation-build.js
• src/lambda/translations.js
• src/lambda/txs.js

src/utils

• src/utils/calculateStakingRewards

Related Issue

#6392

[gatsby-cloud]

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 16m

Performance

Lighthouse report

Metric	Score
Performance	🔶 20
Accessibility	💚 100
Best Practices	💚 100
SEO	💚 92

🔗 View full report

[minimalsm]

Hey @WilliamWelsh, thanks for the PR 😎

I'm a TypeScript noob so I'll leave it to @pettinarip to double-check this. I've left a few open questions that I'm unsure of (though I might be entirely wrong 🙂)

I can't comment directly on the file but for the eth-upgrade-articles I think we should be explicitly declaring types e.g.:

interface Article {
  title: string,
  description: string,
  link: string,
}

[WilliamWelsh]

Hey @WilliamWelsh, thanks for the PR 😎

I'm a TypeScript noob so I'll leave it to @pettinarip to double-check this. I've left a few open questions that I'm unsure of (though I might be entirely wrong 🙂)

I can't comment directly on the file but for the eth-upgrade-articles I think we should be explicitly declaring types e.g.:

interface Article {
  title: string,
  description: string,
  link: string,
}

You're right, I went ahead and added the article type. I also noticed that benArticles's titles were numbered incorrectly so I fixed that as well. Thank you :)

[pettinarip]

This is looking amazing @WilliamWelsh thanks for tackling so many files. Left a couple of comments there. LMK if you have any question.

[pettinarip]

@WilliamWelsh a few small comments, the rest is looking great.

[pettinarip]

LGTM! thanks for the contribution @WilliamWelsh

[pettinarip]

@all-contributors please add @WilliamWelsh for code

[allcontributors]

@pettinarip

I've put up a pull request to add @WilliamWelsh! 🎉