Feat/convert ts d files #6548
Merged
Feat/convert ts d files #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdusart
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 16m PerformanceLighthouse report
|
pettinarip
requested changes
Jun 3, 2022
There was a problem hiding this comment.
Hey @vdusart Thanks for the work here. I left a couple of comments to improve the definitions and others to follow conventions. Gj 💪🏼
|
Ok @pettinarip, I corrected all your comments, thanks for that. I will try to apply all of them for the next ones 😉 |
pettinarip
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Awesome, thanks @vdusart!
Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳 !
|
@all-contributors please add @vdusart for code |
|
I've put up a pull request to add @vdusart! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to TS
Related Issue
Conversion to TS according to #6392