Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet listing policy #6622

Merged
merged 10 commits into from
Jun 17, 2022
Merged

Wallet listing policy #6622

merged 10 commits into from
Jun 17, 2022

Conversation

corwintines
Copy link
Member

Description

  • Create new wallet listing page

Related Issue

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Jun 9, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 9, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 13m

Performance

Lighthouse report

Metric Score
Performance 🔶 20
Accessibility 💚 91
Best Practices 💚 100
SEO 💚 92

🔗 View full report

src/content/contributing/adding-wallet/index.md Outdated Show resolved Hide resolved
src/content/contributing/adding-wallet/index.md Outdated Show resolved Hide resolved
src/content/contributing/adding-wallet/index.md Outdated Show resolved Hide resolved
src/content/contributing/adding-wallet/index.md Outdated Show resolved Hide resolved
src/content/contributing/adding-wallet/index.md Outdated Show resolved Hide resolved
src/content/contributing/adding-wallet/index.md Outdated Show resolved Hide resolved
@corwintines
Copy link
Member Author

Thanks @lukassim!

@samajammin
Copy link
Member

We should also update the issue template to link to this new page:
https://github.com/ethereum/ethereum-org-website/blob/dev/.github/ISSUE_TEMPLATE/suggest_wallet.yaml

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Suggested a few changes.

@corwintines
Copy link
Member Author

@samajammin added your change requests :)

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice job @corwintines!

@wackerow
Copy link
Member

@samajammin I see you blocked with change requests... checked these over, all requests/suggestions have been implemented. I'm gonna go ahead and bring this in, but obviously if you see any other needed changes just ping and we can update before a deploy.

@wackerow wackerow merged commit db51793 into dev Jun 17, 2022
@wackerow wackerow deleted the wallet-listing-policy branch June 17, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants