Convert file to ts #7092
Convert file to ts #7092
Conversation
vdusart
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 11m |
There was a problem hiding this comment.
LGTM @vdusart 💪🏼 I've only added the Gatsby auto generated query types to the get-eth page. The rest is perfect.
src/data/CreateWallet.ts
Outdated
| @@ -1,18 +1,20 @@ | |||
| // This content is used as a code example in /src/pages/index.js | |||
| // Kept here for easy formatting. | |||
There was a problem hiding this comment.
@samajammin from the comment I suspect that we shouldn't migrate this file to TS. Or maybe we can just delete it since it is not being used by other files. Let us know if you want to keep it as it is.
Sorry @vdusart for not detecting this question before. I know this file was on the list. Lets wait for Sam's confirmation before merging this 👍🏼
There was a problem hiding this comment.
@samajammin from the comment I suspect that we shouldn't migrate this file to TS. Or maybe we can just delete it since it is not being used by other files. Let us know if you want to keep it as it is.
Sorry @vdusart for not detecting this question before. I know this file was on the list. Lets wait for Sam's confirmation before merging this 👍🏼
Yes sure, no worries about that 😁
There was a problem hiding this comment.
That is right. From a conversation with Sam, let's keep this file in .js format as the plan is to import it in the code example block that you mentioned. See #7150 for more context.
There was a problem hiding this comment.
Oh ok !
I'm gonna revert the changes on this file then and do the refactor to import the files 😄
There was a problem hiding this comment.
Ok, cool. If possible lets do that refactor in a different PR so that we can merge this one earlier and to have things separated. What do you think?
There was a problem hiding this comment.
Yes of course, it doesn't really make sense to make the changes here. I asked sam to assign me the issue #7150 .
Moving files to TS.
Related Issue
Conversion to TS according to #6392