-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post-merge epic: update pow page #7105
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8b0914c
update pow index for post-merge
jmcook1186 fd4fc29
upgrade note to banner
jmcook1186 a842b27
revert gas page changes in pow branch
jmcook1186 0c51dc4
Update src/content/developers/docs/consensus-mechanisms/pow/index.md
jmcook1186 c12f0f0
Apply suggestions from code review
jmcook1186 2570e03
Merge branch 'post-merge' into pow-index
minimalsm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here, "mining" is just the act of finding the nonce that results in a block hash with an adequate number of leading binary zeros by brute-force hashing. By finding this nonce, it provide proof that the work was performed. I believe it would be more correct to say the underlying algorithm that adjusts the difficulty is the Nakamoto Consensus mechanism which uses PoW.
@jmcook1186 Thought on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure - in Geth the difficulty calculation is part of the Ethash package - it's just a simple comparison between the change in time taken to mine a block relative to its parent and a threshold. To me it feels fine to describe it as part of PoW.