Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-merge updates: merge page #7131

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Conversation

jmcook1186
Copy link
Contributor

@jmcook1186 jmcook1186 commented Jul 19, 2022

Description

Updates merge page, mostly deletions and swapping to past tense.

Related Issue

#7075

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 19, 2022

Gatsby Cloud Build Report

🚩 Your build failed. See the build logs here

Errors

"gatsby-plugin-mdx" threw an error while running the onCreateNode lifecycle:

/usr/src/app/www/src/content/upgrades/merge/index.md: Unterminated JSX contents. (142:16)

  140 | 

{`Further reading {#further-reading}`}

141 | > 142 | | ^ 143 | ) 144 | }; 145 | MDXContent.isMDXComponent = true/usr/src/app/www/src/content/upgrades/merge/index.md: /usr/src/app/www/src/content/upgrades/merge/index.md: Unterminated JSX contents. (142:16) 140 |

{`Further reading {#further-reading}`}

141 | > 142 | | ^ 143 | ) 144 | }; 145 | MDXContent.isMDXComponent = true

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcook1186 Comments below =)

src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
src/content/upgrades/merge/index.md Outdated Show resolved Hide resolved
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just found a couple small edits.

@wackerow wackerow merged commit a815ddc into post-merge Aug 15, 2022
@wackerow wackerow deleted the jc-post-merge-merge-page branch August 15, 2022 22:11
---

<UpgradeStatus dateKey="page-upgrades-merge-date">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should entirely delete this - we should add the ship date like on the Beacon Chain page:
Image 2022-08-23 at 8 26 57 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants