UI lib - new theme colors #7375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm and
jmcook1186
as code owners
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 13m |
pettinarip
force-pushed
the
theme-colors
branch
from
ca5576d to
8045947
Compare
pettinarip
commented
Aug 11, 2022
| // define old colors from the old theme as semanticTokens to transition | ||
| // from emotion components to chakra | ||
| // TODO: remove these colors as we migrate away from them | ||
| ...oldColors, |
There was a problem hiding this comment.
This is to do the migration as seamless as possible. Detailed in the migration guide under the ## Theme colors header. #7368
The idea is that we keep using the same color variable names.
corwintines
reviewed
Aug 12, 2022
corwintines
reviewed
Aug 12, 2022
Co-authored-by: Corwin Smith <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines base theme colors.
Description
Design System colors: https://www.figma.com/file/NrNxGjBL0Yl1PrNrOT8G2B/ethereum.org-Design-System
Related Issue
Fixes #7374
Epic #6374