post-merge updates: sql tutorial #7484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcook1186
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
59 tasks
Gatsby Cloud Build Reportpost-merge 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m |
minimalsm
reviewed
Aug 19, 2022
src/content/developers/tutorials/learn-foundational-ethereum-topics-with-sql/index.md
Outdated
Show resolved
Hide resolved
…opics-with-sql/index.md
minimalsm
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
LGTM.
I noticed this in the article:
To see that there is one block produced approximately every 15 seconds, we could take the number of seconds in a day (86400) divided by 15 to get an estimate average number of blocks per day (~ 5760).
But I don't think we should fix it as it's tightly coupled to the content and screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates sql tutorial as part of post-merge updates. Most changes not really merge-specific but actually reflect changes due to eip1559.
Related Issue
#7075