Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post-merge banner and remove pre-merge banner #7544

Merged
merged 5 commits into from
Sep 5, 2022
Merged

Add post-merge banner and remove pre-merge banner #7544

merged 5 commits into from
Sep 5, 2022

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Aug 23, 2022 •
edited
Loading

Description

  • Create and implement PostMergeBanner
  • Removes PreMergeBanner

Related Issue

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Aug 23, 2022
@corwintines corwintines mentioned this pull request Aug 23, 2022
Closed
59 tasks
jmcook1186
jmcook1186 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@minimalsm minimalsm added the Status: Blocked 🛑 This is blocked label Aug 25, 2022
@minimalsm
Copy link
Contributor

Blocked until we sort the post-merge branch.

Crowdin has markdown files with the postMerge frontmatter, so we should probably double check we've removed them also after the latest Crowdin update (Would this break builds?).

@minimalsm minimalsm removed the content 🖋️ This involves copy additions or edits label Aug 25, 2022
@minimalsm minimalsm changed the title Post merge banner Add post-merge banner and remove pre-merge banner Aug 25, 2022
@vercel
Copy link

vercel bot commented Sep 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ethereum-org-website ❌ Failed (Inspect) Sep 5, 2022 at 3:09PM (UTC)

@minimalsm minimalsm merged commit a626656 into post-merge Sep 5, 2022
@minimalsm minimalsm deleted the postMergeBanner branch September 5, 2022 14:23
@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Sep 5, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 5, 2022

Gatsby Cloud Build Report

🚩 Your build failed. See the build logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow

@pettinarip pettinarip Awaiting requested review from pettinarip

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits Status: Blocked 🛑 This is blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corwintines @minimalsm @jmcook1186