Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-merge update: glossary #7592

Merged
merged 2 commits into from
Sep 5, 2022
Merged

post-merge update: glossary #7592

merged 2 commits into from
Sep 5, 2022

Conversation

jmcook1186
Copy link
Contributor

Description

updates glossary for post merge

Related Issue

#7075
#2277

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ethereum-org-website ❌ Failed (Inspect) Aug 31, 2022 at 3:50PM (UTC)

@@ -371,9 +374,9 @@ A label given to some [EIPs](#eip) that attempt to define a specific standard of

### Ethash {#ethash}

A [proof-of-work](#pow) algorithm for Ethereum 1.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops how did this slip by lol

Comment on lines 375 to +379
### Ethash {#ethash}

A [proof-of-work](#pow) algorithm for Ethereum 1.0.
A [proof-of-work](#pow) algorithm that was used on Ethereum before it transitioned to [proof-of-stake](#pos).

[Read more at eth.wiki](https://eth.wiki/en/concepts/ethash/ethash)
[Read more](/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on removing this entirely? Doesn't have to be now but I don't think it's necessary to keep it in the glossary forever...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk i think it's good to keep for now - people will still hear about it in various places and it's good to have a simple explanation and clarify that it's no longer used.

@@ -602,7 +602,7 @@ A special type of [contract](#smart-contract) that has no payable functions, no
Smart Contract Libraries
</DocLink>

### lightweight client {#lightweight-client}
### light client {#light-client}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. We use a couple of naming conventions across the site that we should fix eventually.

@@ -644,15 +644,15 @@ The third development stage of Ethereum, launched in October 2017.

### mining {#mining}

The process of verifying transactions and contract execution on the Ethereum blockchain in exchange for a reward in ether with the mining of every block.
The process of verifying transactions and contract execution on the Ethereum blockchain in exchange for a reward in ether with the mining of every block. This was how Ethereumw as secured before it moved to [proof-of-stake](#pos).

### mining pool {#mining-pool}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this in glossary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess ignore these comments for now. Maybe as a post-merge clean-up, we can discuss the possibility of removing outdated lingo from the glossary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it. People will definitely be confused about what happened to mining and where it fits in Ethereum for a long time after TM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my comment was specifically about mining pools, but your point. still seems valid.

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for suggested tweaks/typos but looks good to me overall.

Meta comment for a later discussion: when should we remove certain terminology that was tightly coupled to pow Ethereum (mining pools, Ethash, etc)?

@minimalsm minimalsm merged commit 5f35ea0 into post-merge Sep 5, 2022
@minimalsm minimalsm deleted the jc-post-merge-glossary branch September 5, 2022 14:19
@minimalsm minimalsm mentioned this pull request Sep 5, 2022
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants