refine upgrades page for post-merge #7961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcook1186
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
requested changes
Sep 22, 2022
|
@jmcook1186 just flagging changes requests here incase you haven't seem them. |
Co-authored-by: Joshua <[email protected]>
jmcook1186
commented
Oct 5, 2022
|
Hi @minimalsm I made the requested changes and resolved the merge conflicts - can you take a look? |
wackerow
reviewed
Oct 21, 2022
wackerow
reviewed
Oct 21, 2022
wackerow
approved these changes
Oct 21, 2022
minimalsm
approved these changes
Oct 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Upgrades page still referred to the Merge in the future tense and required some rewriting.
Related Issue
#7075