Post-merge cleanup #8069
Merged
Post-merge cleanup #8069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
samajammin,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
github-actions
bot
added
content 🖋️
samajammin
reviewed
Sep 28, 2022
src/components/Layout.tsx
Outdated
| @@ -180,7 +165,7 @@ const Layout: React.FC<IProps> = ({ | |||
| <Nav path={path} /> | |||
| {shouldShowSideNav && <SideNavMobile path={path} />} | |||
| </VisuallyHidden> | |||
| <BannerNotification | |||
| {/* <BannerNotification | |||
There was a problem hiding this comment.
I suspect we should remove the "merge-complete" string from common.json?
There was a problem hiding this comment.
Oops, good catch. Removing string and comment now.
samajammin
suggested changes
Sep 28, 2022
✅ ethereum-org-website-dev deploy preview ready
|
samajammin
approved these changes
Sep 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hero-panda.pngreact-rewardspackageRelated Issue
#7075