Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates merge impact on ether issuance page [Closes #7873] #8329

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 22, 2022

Description

  • Updates the "How The Merge impacted ETH supply" page located at /upgrades/merge/issuance
  • This copy update intentionally keeps the comparison to a pre-merge PoW world, so users have a comparison from what the issuance is now compared to what is was prior to The Merge.
  • Adds a section on "Calculating average gas price for deflation" which dives into some math surrounding how to calculate the average gas price needed to completely offset the issuance.

Related Issue

Note, PR #7921 was also put up to address updated ETH issuance, but removes the comparison to pre-merge Ethereum. After some discussion and given this page is located at /upgrades/merge/issuance, recommending we table that PR for now and plan to create a separate subpage located underneath the /eth path as noted in this comment such as /eth/issuance.

Another note, in the future it would be nice to have issue #7653 addressed to enable displaying these mathematical expressions in a more appropriate manner. If/when that issue is completed, we should circle back to this content and update these expressions to use Latex mathematical expressions instead of code snippets.

Preview link

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 22, 2022

✅ ethereum-org-website-dev deploy preview ready

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestion for making tenses consistent in one paragraph. Otherwise looking great!

@wackerow wackerow requested a review from jmcook1186 October 26, 2022 14:51
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @wackerow !

How ETH gets issued will change at the time of The Merge. Currently, new ETH is issued from two sources: the execution layer (i.e. Mainnet) and the consensus layer (i.e. Beacon Chain). After The Merge, issuance from the execution layer will go to zero. Let's break this down.

[More on The Merge](/upgrades/merge/)
<!-- How ETH gets issued changed at the time of The Merge, which occurred in September 2022. Previously, new ETH was issued from two sources: the execution layer (i.e. Mainnet) and the consensus layer (i.e. Beacon Chain). Since The Merge, issuance on the execution layer is now zero. Let's break this down. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be removed?


### Consensus layer issuance {#cl-issuance-post-merge}

Consensus layer issuance will continue as before The Merge, with small rewards for validators who attest to and propose blocks. Validator rewards will continue to accrue to _validator balances_ that are managed within the consensus layer. These are separate Ethereum accounts to the accounts we're used to on Mainnet, and until the Shanghai upgrade funds from validator accounts will not be withdrawable/transferrable. This means that although new ETH is still being issued, 100% of it will be locked from the market until this upgrade occurs. When the Shanghai upgrade is rolled out, this ETH will become available.
Consensus layers issuance continues today as it did prior to The Merge, with small rewards for validators who attest to and propose blocks. Validator rewards continue to accrue to _validator balances_ that are managed within the consensus layer. These are separate Ethereum accounts to the accounts we're used to on Mainnet, and until the upcoming Shanghai upgrade funds from validator accounts will not be withdrawable/transferrable. This means that although new ETH is still being issued, 100% remains locked from the market until this upgrade occurs. When the Shanghai upgrade is rolled out, this ETH will become available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Consensus layers issuance continues today as it did prior to The Merge, with small rewards for validators who attest to and propose blocks. Validator rewards continue to accrue to _validator balances_ that are managed within the consensus layer. These are separate Ethereum accounts to the accounts we're used to on Mainnet, and until the upcoming Shanghai upgrade funds from validator accounts will not be withdrawable/transferrable. This means that although new ETH is still being issued, 100% remains locked from the market until this upgrade occurs. When the Shanghai upgrade is rolled out, this ETH will become available.
Consensus layer issuance continues today as it did prior to The Merge, with small rewards for validators who attest to and propose blocks. Validator rewards continue to accrue to _validator balances_ that are managed within the consensus layer. These are separate Ethereum accounts to the accounts we're used to on Mainnet, and until the upcoming Shanghai upgrade funds from validator accounts will not be withdrawable/transferrable. This means that although new ETH is still being issued, 100% remains locked from the market until this upgrade occurs. When the Shanghai upgrade is rolled out, this ETH will become available.

Think this reads a little more clear, but not a string opinion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also noting the text around shanghai upgrade. Im fine with this as Vitalik and others have basically said it will be in Shanghai, but we did have comments in the past about this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, despite the exact list of EIPs not being solidified yet, there seems to be consensus on withdraws being prioritized and I'm comfortable with the wording at this point.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments want to clear up.

@corwintines corwintines merged commit 5e15a09 into dev Oct 27, 2022
@corwintines corwintines deleted the post-merge-issuance branch October 27, 2022 18:41
@corwintines corwintines mentioned this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ETH issuance page for post-Merge
4 participants