add page on block proposal #8446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcook1186
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
requested changes
Nov 3, 2022
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,71 @@ | |||
| --- | |||
| title: Block proposal | |||
There was a problem hiding this comment.
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/
Thoughts on the location of this page? Other than complexity, I feel like this being a subpage of blocks makes sense. Not cut-and-dry, would love opinions here.
cc: @wackerow @samajammin
There was a problem hiding this comment.
I could see it going in either place honestly. I think given the complexity and prereq's that include PoS, I would opt to just keep it here under consensus-mechanisms/pos
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua <[email protected]>
wackerow
reviewed
Nov 7, 2022
| @@ -0,0 +1,71 @@ | |||
| --- | |||
| title: Block proposal | |||
There was a problem hiding this comment.
I could see it going in either place honestly. I think given the complexity and prereq's that include PoS, I would opt to just keep it here under consensus-mechanisms/pos
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Paul Wackerow <[email protected]>
minimalsm
requested changes
Dec 7, 2022
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pos/block-proposal/index.md
Outdated
Show resolved
Hide resolved
minimalsm
approved these changes
Dec 7, 2022
Co-authored-by: Joshua <[email protected]>
…posal/index.md Co-authored-by: Joshua <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds new page to
consensus-mechanisms/posdescribing the process of proposing a block, including validator selection, block creation and propagation and block rewards. Part of the "post-merge gaps" epic.Related Issue
#8285