add page on node architecture #8449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcook1186
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
requested changes
Nov 3, 2022
There was a problem hiding this comment.
Nice :-) Overall looks great 🎉
The biggest question I have here is about the introduction section. I feel like we might be going a little too deep on execution/consensus explanations before their relevant sections. Quite subjective, but I feel like with it being a relatively complicated subject, it might be worth the effort to consider if we can architect (ha) this page a little more clearly.
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
minimalsm
reviewed
Nov 3, 2022
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
…hereum-org-website into jc-node-architecture
Co-authored-by: Joshua <[email protected]>
Co-authored-by: Joshua <[email protected]>
jmcook1186
commented
Nov 7, 2022
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Show resolved
Hide resolved
jmcook1186
commented
Nov 7, 2022
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
minimalsm
requested changes
Dec 9, 2022
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
minimalsm
reviewed
Dec 9, 2022
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Outdated
Show resolved
Hide resolved
minimalsm
reviewed
Dec 9, 2022
src/content/developers/docs/nodes-and-clients/node-architecture/index.md
Show resolved
Hide resolved
minimalsm
approved these changes
Dec 13, 2022
github-actions
bot
added
the
abandoned
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a page explaining the architecture of a pos Ethereum node.
Related Issue
#8285