-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n lib change - use htmr
to parse html inside json files
#8585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send "1" for correct answer, "0" for incorrect
Moved smart contract auditing services and bug bounty platforms from the [testing page](https://ethereum.org/en/developers/docs/smart-contracts/testing/) to the smart contract security page. I gave some context on the proposal [here](#8362 (comment)).
Fix formatting on rewards and penalties page
Add Balancer to dapps
source: Beaconcha.in
Removed duplicate 'can'
docs: add florath as a contributor for doc
Fix link overlay in `CardList`
convert the Pill component to Chakra
…s-color-mode-usage refactor(upgrade-status): implement `useColorModeValue`
Fix unstyled links living in the JSON files [Fixes #8547]
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Add auditing services and bug bounty platforms to SC security page
pettinarip
commented
Nov 14, 2022
@@ -1,12 +1,26 @@ | |||
import React from "react" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main change is in this file.
❌ ethereum-org-website-react-i18n deploy preview failedYour build failed. View the build logs. Errors [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/community.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/layer-2.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/wallets/find-wallet.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/index.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/upgrades/index.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/stablecoins.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/bug-bounty.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/learn/index.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/run-a-node.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages-conditional/what-is-ethereum.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages-conditional/dapps.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/community.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/wallets/find-wallet.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/layer-2.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/upgrades/index.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/index.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/bug-bounty.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/stablecoins.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/learn/index.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages/run-a-node.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages-conditional/what-is-ethereum.tsx as it exceeds the max of 500KB. [BABEL] Note: The code generator has deoptimised the styling of /usr/src/app/www/src/pages-conditional/dapps.tsx as it exceeds the max of 500KB. Building static HTML failed |
Update Matomo tracking eventValue for QuizWidget
Refactor VisuallyHidden component to use ChakraUI
Update German (de) Staking, Learn 2, and Contributing buckets
Use latest value from Beaconcha.in endpoint
Note: build is failing bc of this issue #8589 |
Fix closing link tag in Arabic translation file
remove ftx from get-eth
….io-parser-4.0.5 Bump socket.io-parser from 4.0.4 to 4.0.5
Update template from `Staking` to `staking` in German md files
Closing this PR since it got super messed up xD New PR: #8592 |
corwintines
added a commit
that referenced
this pull request
Nov 24, 2022
i18n lib change - use htmr to parse html inside json files #8585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
abandoned
This has been abandoned or will not be implemented
content 🖋️
This involves copy additions or edits
dependencies 📦
Changes related to project dependencies
tooling 🔧
Changes related to tooling of the project
translation 🌍
This is related to our Translation Program
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of
dangerouslySetInnerHTML
(for security reasons) to insert html content from the translation files. Instead, it uses the htmr lib where we can also use our own custom components (similar to we do with markdown files).Description
dangerouslySetInnerHTML
htmr
to parse the inner html that json files may haveRelated Issue
#8345