Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert i18n PR #8786

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Revert i18n PR #8786

merged 2 commits into from
Nov 29, 2022

Conversation

pettinarip
Copy link
Member

Description

Reverts #8406 since it is causing memory issues on our master env site in GC.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies review needed 👀 tooling 🔧 Changes related to tooling of the project labels Nov 29, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 29, 2022

✅ ethereum-org-website-dev deploy preview ready

minimalsm
minimalsm approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minimalsm minimalsm merged commit 82dd4c7 into dev Nov 29, 2022
@minimalsm minimalsm deleted the revert-i18n-pr branch November 29, 2022 20:28
@minimalsm minimalsm mentioned this pull request Nov 29, 2022
Merged
pettinarip added a commit that referenced this pull request Dec 10, 2022
@pettinarip
Revert "Merge pull request #8786 from ethereum/revert-i18n-pr"
1798fe5 
This reverts commit 82dd4c7, reversing
changes made to b24db7d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pettinarip @minimalsm