-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChakraUI: Migrate FileContributors.tsx [#8636] #9878
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SyedAhkam great work here. I liked the direction you took on adjusting the Modal to use the chakra modal.
I've only added a few changes:
- conventions like
p="2"
=>p={2}
orp="1rem"
=>p={4}
- removed some abstractions that were not totally necessary
- cleanup some styles that were not necessary in a few components
I'll finish testing it soon but in general I think this is ready to be approved.
Thanks! Ahh I'm not that familiar with ChakraUI so I'm not aware of all the prop conventions yet. I'll surely look into it. I totally understand how you feel about unnecessary abstractions, I got a bit carried away trying to provide a 1:1 migration to the old codebase and that left me with components like I'm glad that you liked my implementation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Migrated FileContributors.tsx to Chakra UI
Description
Contributing to the UI Library Epic: #6374
I have migrated many components that made up the
FileContributors
Component.Modal
component in Modal.tsxContributor
andContributorList
components using chakra primitives.Skeleton
components using components from chakra.Container
,SkeletonButtonContainer
, andButtonContent
and replaced them with simpleFlex
widgets.Icon
component to new chakra basedIcon
Modal
vertically, unlike the previous implementation.The results wielded might seem slightly inconsistent, but I left them intentionally because it seemed better that way.
Related Issue
Solves #8636