Add EIP-7251 to Prague #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! 👍 I’d like to see the corresponding change to the EIP-7002 in the first place, or at least a PR with the change |
|
Here is the PR to the EIP: ethereum/EIPs#8406 |
lightclient
reviewed
Apr 11, 2024
lightclient
approved these changes
Apr 11, 2024
mkalinin
approved these changes
Apr 12, 2024
|
One thing that we’ll have to do is to rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since EIP-7251 is included into Pectra fork. We should consider including it in the Engine API spec.
One of the features of EIP-7251 is to integrate EIP-7002 to support execution layer triggerable partial withdrawals via
ExitV1.This PR adds
amounttoExitV1such that it supports partial withdrawals on top of full exits.A point of discussion is the use of word
exit. Originally EIP-7002 only considers full withdrawals (exits). With the newly added responsibility, one may consider renamingexittoexecutionLayerWithdrawfor more precise description and to be distinguishable from the current withdrawal mechanism (consensus layer triggered).