Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove comma from base types pattern #538

Merged
merged 1 commit into from
Apr 24, 2024
Merged

remove comma from base types pattern #538

merged 1 commit into from
Apr 24, 2024

Conversation

shanejonas
Copy link
Contributor

@shanejonas shanejonas commented Apr 23, 2024 •
edited
Loading

im using this schema and json schema faker and this address schema pattern generates addresses with commas in them:

image

also removed them from byte while I was in there

@shanejonas
remove comma from base types pattern
648c409 
im using this schema and json schema faker to generate tests and this address schema pattern generates addresses with commas in them
lightclient
lightclient approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lightclient lightclient merged commit 1a87948 into ethereum:main Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanejonas @lightclient