Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade questionary to allow compatbility with ipython #966

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Nov 22, 2024

🗒️ Description

This PR fixes interactive usage of EEST with ipython.

I tested this change on top of dac9049 from raxhvl/feat/make-test cf #950: The interactive CLI command uv run et make test works without a problem with these changes, CC @raxhvl .

Here's the explanation from pyproject.toml:

    # TODO: bump questionary to a newer release, when it becomes available. 
    # The current release questionary 2.0.1 requires `prompt_toolkit = ">=2.0,<=3.0.36"`.
    # This conflicts with ipython; while not an EEST dependency, ipython a very useful tool:
    # https://ethereum.github.io/execution-spec-tests/main/dev/interactive_usage/
    "questionary @ git+https://github.com/tmbo/questionary@ff22aeae1cd9c1c734f14329934e349bec7873bc",
    "prompt_toolkit>=3.0.48,<4",  # ensure we have a new enough version for ipython

🔗 Related Issues

This issue was introduced in #947

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.

@danceratopz danceratopz added type:chore Type: Chore scope:tooling Scope: Python tools (uv, ruff, tox,...) labels Nov 22, 2024
Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for interactive question setup ?

@danceratopz
Copy link
Member Author

is this for interactive question setup ?

Yes, you can try it out in raxhvl's linked branch.

@danceratopz danceratopz merged commit 73f8cd5 into main Nov 22, 2024
5 checks passed
@danceratopz danceratopz deleted the fix/ipython branch November 22, 2024 10:28
@danceratopz danceratopz restored the fix/ipython branch November 22, 2024 10:31
@danceratopz danceratopz self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tooling Scope: Python tools (uv, ruff, tox,...) type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants