Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Fix overflown callstack trace bug #16687

Closed
wants to merge 1 commit into from

Conversation

linuxion
Copy link

@linuxion linuxion commented May 5, 2018

The problem and the fix are described here.

If @olebedev merges my PR, you can undo the changes using

govendor update gopkg.in/olebedev/go-duktape.v3::gopkg.in/olebedev/go-duktape.v3
govendor update gopkg.in/olebedev/go-duktape.v3

if necessary.

@linuxion
Copy link
Author

@karalabe, just a reminder. You have done a lot of cool geth improvements last 2 months, but it is a little inconvenient to recompile geth each update. :(

@AyushyaChitransh
Copy link
Contributor

Pinging to check if this PR is ready.

@holiman
Copy link
Contributor

holiman commented Jan 17, 2019

I'm not a fan of this. It changes the vendoring into gopkg.in/linuxion/go-duktape.v3. I'd much prefer it if the original maintainer merged that PR instead of us vendoring a fork.

@karalabe
Copy link
Member

I think our choices here are 1) upstream the change; 2) make this thing configurable and not baked in; 3) pull the entire ducktape code into our repo. The best would be 2, but someone needs to champion that upstream.

@karalabe
Copy link
Member

If not 2, I'd go with 3 (we already have ducktape vendored in, so it's just moving form vendor to embed).

@holiman
Copy link
Contributor

holiman commented Feb 7, 2019

Just pinged upstream

@holiman
Copy link
Contributor

holiman commented Feb 7, 2019

Closing this, as we'd rather use an upstream fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants