Migrate new go-ethereum website built with Next.js #26374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Corwin Smith <[email protected]>
% not supported for letterSpacing, 'auto' not supported for lineHeight
using DocSearch component via @docsearch/react library
Markdown styling
* chore: update textStyles * markdown text color styles Co-authored-by: Corwin Smith <[email protected]>
* chore: update constants * feat: add releases data utils * chore: add fast-xml-parser * chore: update types * feat: fetch & parse all releases data * chore: update utils * wip: use real data on DataTable * chore: update yarn.lock * fix: getReleaseCommitHash * feat: filter data per downloads tab * chore: update DownloadsTable * chore: update DownloadsTable Props * fix: getReleaseArch.ts * feat: add fetchXMLData util * feat: add fetchLatestReleaseCommit util * feat: add getSortedReleases util * chore: comment wip primary release feature * fix: fetchXMLData * chore: add netlify.toml * fix: total number of releases count * fix: center showing latest releases text and use smaller font * chore: prettier * chore: update textStyles * fix: merge conflicts
Co-authored-by: Paul Wackerow <[email protected]>
chore: update metadata image
…age (#64) * chore: update SpecificVersionsSection component layout to match homepage * chore: remove non-required repeat function
chore: update h2 font-size
Co-authored-by: Paul Wackerow <[email protected]>
feat: add favicon
…-headings-letter-spacing
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Paul Wackerow <[email protected]>
Fix logic for which docs sections are open
wackerow
requested review from
holiman,
fjl,
zsfelfoldi,
karalabe,
ligi,
rjl493456442,
gballet,
s1na and
MariusVanDerWijden
as code owners
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 5133149 | Generic High Entropy Secret | 5646bc1 | src/components/UI/Search.tsx | View secret |
| 5133149 | Generic High Entropy Secret | 7913090 | src/components/UI/Search.tsx | View secret |
| 5133149 | Generic High Entropy Secret | 7913090 | src/components/UI/Search.tsx | View secret |
| 5133149 | Generic High Entropy Secret | 5646bc1 | src/components/UI/Search.tsx | View secret |
| 5133149 | Generic High Entropy Secret | 7913090 | src/components/UI/Search.tsx | View secret |
| 5133149 | Generic High Entropy Secret | 7913090 | src/components/UI/Search.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Note the security alert related to API keys is a false positive, as the keys used in these commits were publicly available keys provided by Algolia for testing |
fix: broken paths
* add missing redirect * fix: contributing links Co-authored-by: Nicolás Quiroz <[email protected]>
|
It's very weird. I marked this finding as Ignored and can confirm it in GitGuardian dashboard, but for some reason it still blocks the Github checks 🤯 I emailed GitGuardian support. PR is safe to be merged. |
Aldekein
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch:
websiteDescription
The go-ethereum website front end has been getting a revamp and is ready for launch! 🎉
See Epic Tracker: ethereum/geth-website#1
This PR is a migration of the codebase at ethereum/geth-website
masterbranch, which has been acting as the dev repo while establishing an initial release of the new site. Similar to the currentgh-pagesbranch of this repo, a dedicatedwebsitebranch has been created to act as the home for the go-ethereum website front end codebase.This site is a React site built using Next.js, written in TypeScript, using Chakra-UI for design components, and Algolia for search functionality. The site intends to reach parity with the existing site while implementing several near features and enhancements, including but not limited to:
cc: @fjl @jmcook1186