geth.txpool async request

[dbfreem]

What was wrong?

I wanted to go ahead and put this out here as a work in progress to get feedback on if this is the right path for starting to add async to the geth package.

Issue #1413

How was it fixed?

Todo:

• Add entry to the release notes

[dbfreem]

Working on fixing the typing. Went back and forth on ignore typing for the async methods since the call the same method as the sync methods in tx_pool.py. The options I saw were to duplicate the method in tx_pool.py and change the return type or ignore the typing. I saw in eth.py the typing was ignored in this scenario so I went that route.

I Still need to look and see why linting is calling out typing in the testing module.

[dbfreem]

I had a question about test_txpool_content.py and test_txpool_inspect.py. I put the test for this PR in the Module testing as it seems like other async testing was placed there.

It seems like the test in test_txpool_content and test_txpool_inspect are always going to be skipped since they will always rollup to the web3 fixture in the root conftest.py and the EthereumTestProvider causes these test to be skipped by skip_if_testrpc. It seems like these unit test should be included in the module testing but I could be wrong here, just curious what I might be missing here.

[dbfreem]

This PR is ready for review

[kclowes]

Will take a look! Thank you!

[kclowes]

This looks good to me, thanks for taking it on! I just left one doc change, and one request for adding a test. Let me know what you think!

[kclowes]

I saw in eth.py the typing was ignored in this scenario so I went that route.

Thanks, that's the preferred approach for now. Hopefully we'll be able to figure out something a little nicer down the road.

It seems like the test in test_txpool_content and test_txpool_inspect are always going to be skipped since they will always rollup to the web3 fixture in the root conftest.py and the EthereumTestProvider causes these test to be skipped by skip_if_testrpc. It seems like these unit test should be included in the module testing but I could be wrong here, just curious what I might be missing here.

Yes, you're right that they will get skipped. I'm not sure why they're in the core tests. We can probably get rid of them, but I'll do that in another PR.

Thanks!

[dbfreem]

@kclowes I fixed those issues and this is ready for review

[kclowes]

Thank you @dbfreem! This looks good to me. I'll make a quick commit with the lint fix and some whitespace changes and then get this merged!