vm/tx: update 7702 to devnet-4 #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
force-pushed
the
7702-devnet-4-plus-t8ntool
branch
from
9baab30
to
735ed26
Compare
jochem-brouwer
force-pushed
the
7702-devnet-4-plus-t8ntool
branch
from
735ed26
to
bcfc8f6
Compare
|
For completeness: I also ran the https://github.com/ethereum/execution-spec-tests/releases/tag/pectra-devnet-4%40v1.0.1 state and blockchain tests, we pass all 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following EIP PRs for devnet-4 :
ethereum/EIPs#8845 (removes the
secp256k1/2check ofsof an authority tuple)ethereum/EIPs#8938 (do not allow the
nonceof an authority tuple to be2^64 - 1(NOTE: the check that it is less-than-or-equal-to2^64 - 1is done at the tx level (such that it fits within an uint64), but this check makes it explicit that the authority nonce is not2^64 - 1, because bumping this nonce would make it2^64, thus not fitting within an uint64 anymore)ethereum/EIPs#8929 (revokes delegation mechanism, changes yParity validity at tx-level to fit within a
uint8/bytes1)ethereum/EIPs#8948 (increases
PER_AUTH_BASE_COST, the fee paid when delegating anauthorityaccount which already exists in the trie)Note: descriptions of this PR might look incomplete when checking these individual PRs, however this means that that specific change has been overridden by a newer PR. For devnet-4 this is also included: ethereum/EIPs#8940, however this does not change anything and is just clarifications.
This PR points to (and builds upon) #3706. (I would like to use that PR as devnet-4 base branch)
TODOs
execution-spec-testsfor devnet-4