Skip to content

Commit

Permalink
Merge pull request #709 from etherisc/feature/node_20_lts
Browse files Browse the repository at this point in the history
update node to 20 lts
  • Loading branch information
doerfli authored Dec 27, 2023
2 parents a38bc85 + b563d2a commit 07ec8b4
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 18 deletions.
8 changes: 4 additions & 4 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
"csstools.postcss",
"vscodeshift.mui-snippets",
"mikestead.dotenv",
"vscode-icons-team.vscode-icons",
"vscode-icons-team.vscode-icons"
]
}
},

"containerEnv": {
"PORT": "3100",
"PORT": "3100"
},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
Expand All @@ -44,8 +44,8 @@
// Comment out to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "node",
"features": {
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {},
},
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {}
}

// "mounts": [
// "source=staking-ui-node_modules,target=/workspaces/staking-ui/node_modules,type=volume"
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ services:
context: ..
dockerfile: .devcontainer/Dockerfile
args:
VARIANT: 18-bookworm
VARIANT: 20-bookworm
volumes:
- ..:/workspaces/staking-ui:cached
- staking-ui-node_modules:/workspaces/staking-ui/node_modules
Expand Down
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ updates:
interval: "weekly"
ignore:
- dependency-name: "node"
versions: ["19-alpine"]
versions: ["21-alpine"]
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand All @@ -23,7 +23,7 @@ updates:
open-pull-requests-limit: 30
ignore:
- dependency-name: "@types/node"
versions: ["19.x", "20.x"]
versions: ["21.x"]
- dependency-name: "@etherisc/gif-interface"
# ignore all updates to this dependency
- dependency-name: "@etherisc/depeg-contracts"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: NPM install
run: npm install
Expand All @@ -34,7 +34,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: NPM install
run: npm install
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG VARIANT=node:18-alpine
ARG VARIANT=node:20-alpine
# Install dependencies only when needed
FROM ${VARIANT} AS deps
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@typechain/ethers-v5": "^11.1.2",
"@types/canvas-confetti": "^1.6.4",
"@types/jest": "^29.5.11",
"@types/node": "^18.19.3",
"@types/node": "^20",
"@types/react": "^18.2.45",
"@types/react-blockies": "^1.4.4",
"@types/react-dom": "^18.2.18",
Expand Down

0 comments on commit 07ec8b4

Please sign in to comment.