-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: validator set persistence #200
Draft
pk910
wants to merge
24
commits into
master
Choose a base branch
from
pk910/validators-in-db
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk910
added
the
build-docker-image
Automatically build docker image for PR branch
label
Jan 24, 2025
This branch is now running on https://dora-holesky.pk910.de/ for the holesky testnet. Issues found:
|
…eferenced from the activity cache (huge memory leak for big networks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a validators table to the db and persists the finalized validator set there.
The validator cache is responsible for writing and updating validator entries.
It uses a batched approach for mass updates to keep the db load manageable.
This PR touches a lot of code as the validator set accessors changed.
Instead of fetching the full validator set and doing filtering/aggregation logic in the page handlers, the page handlers will now only fetch a filtered subset of the validator set.
This PR should significantly lower the memory consumption of dora when running in a network with large validator sets (holesky, mainnet)