fix fork detection for forks starting before the finalized checkpoint #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue in the fork detection which was recently triggered in devnet-6:
Root case of the issue has been, that the orphaned chain at slot 1502 started at slot 1185 (epoch 37), and built on top of slot 1067 (epoch 33).
When receiving the orphaned block at slot 1185, dora had already finalized and dropped all blocks from epoch 33 from cache, so the new fork was not detected (no other block in cache building on top of the same parent).
This PR fixes the fork detection, to properly detect such forks by checking for relevant blocks in the db