Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table visual fixes #5693

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Table visual fixes #5693

merged 4 commits into from
Jan 29, 2025

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jan 20, 2025

Closes HJ_390

Description Of Changes

Small visual tweaks to some table buttons:

  • In discovery result table, bulk action buttons at table level now have spacing between them (also drive-by fix to make spacing slightly better)
  • In discovery result table, bulk action buttons at field level are correct size
  • Fix cell padding on "select" cells in some tables

Steps to Confirm

  1. Visually check discovery result table/field tables

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:11pm

@cypress Cypress
Copy link

cypress bot commented Jan 20, 2025 •
edited
Loading

fides    Run #12011

Run Properties:  status check passed Passed #12011  •  git commit b438d449e0 ℹ️: Merge be1d8c9640cfcccbeccccf9981107b8e761dccee into 6bf157aac364b9aabcaf1d808874...
Project fides
Branch Review refs/pull/5693/merge
Run status status check passed Passed #12011
Run duration 00m 49s
Commit git commit b438d449e0 ℹ️: Merge be1d8c9640cfcccbeccccf9981107b8e761dccee into 6bf157aac364b9aabcaf1d808874...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@jpople jpople requested a review from gilluminate January 22, 2025 19:51
gilluminate
gilluminate approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good.
CleanShot 2025-01-22 at 12 40 13@2x

@jpople jpople merged commit 3fd45a1 into main Jan 29, 2025
20 checks passed
@jpople jpople deleted the jpople/hj-390/2-button-2-fixes branch January 29, 2025 18:19
@cypress Cypress
Copy link

cypress bot commented Jan 29, 2025

fides    Run #12014

Run Properties:  status check passed Passed #12014  •  git commit 3fd45a159d: Table visual fixes (#5693)
Project fides
Branch Review main
Run status status check passed Passed #12014
Run duration 00m 49s
Commit git commit 3fd45a159d: Table visual fixes (#5693)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @gilluminate