Skip to content

Commit

Permalink
Put version into the manifest.json on CI builds (Docker, CDN, etc.)
Browse files Browse the repository at this point in the history
This commit fixes the Awesome-Technologies/synapse-admin#507 issue.
While it's a mere workaround, it may help until the
Awesome-Technologies/synapse-admin#507 (comment) is implemented
  • Loading branch information
aine-etke committed Sep 5, 2024
1 parent 01e3947 commit 1474b46
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches: [ "main" ]
env:
upstream_version: v0.10.3
etke_version: etke10
etke_version: etke11
bunny_version: v0.1.0
base_path: ./
permissions:
Expand All @@ -26,6 +26,8 @@ jobs:
cache: yarn
- name: Install dependencies
run: yarn install --immutable --network-timeout=300000
- name: Set version into manifest.json
run: sed -i 's|"icons"|"version": "${{ env.upstream_version }}-${{ env.etke_version }}",\n "icons"|g' public/manifest.json
- name: Build
run: yarn build --base=${{ env.base_path }}
- uses: actions/upload-artifact@v4
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ The following changes are already implemented:
* [Fix redirect URL after user creation](https://github.com/etkecc/synapse-admin/pull/16)
* [Display actual Synapse errors](https://github.com/etkecc/synapse-admin/pull/17)
* [Fix base_url being undefined on unsuccessful login](https://github.com/etkecc/synapse-admin/pull/18)
* [Put the version into manifest.json](https://github.com/Awesome-Technologies/synapse-admin/issues/507) (CI only)

_the list will be updated as new changes are added_

Expand Down

0 comments on commit 1474b46

Please sign in to comment.