Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach OutliersTransform to ignore holidays #22

Closed
Mr-Geekman opened this issue Aug 14, 2023 · 0 comments · Fixed by #291
Closed

Teach OutliersTransform to ignore holidays #22

Mr-Geekman opened this issue Aug 14, 2023 · 0 comments · Fixed by #291
Assignees
Labels
enhancement New feature or request priority/medium Medium priority task

Comments

@Mr-Geekman
Copy link

Issue by alex-hse-repository
Friday Nov 25, 2022 at 15:31 GMT
Originally opened as tinkoff-ai#1017


🚀 Feature Request

Teach OutliersTransform to ignore holidays, which are not outliers in some sense.

Proposal

  1. Add parameters ignore_flag_column: Optional[str] = None -- if set, then it should be column with binary flag of holiday (which might be created from the HolidaysTransform)
  2. Update the transform method: now it should ignore the outliers on dates with true values in ignore_flag_column.
  3. Update the fit method: now it should check the ignore_flag_column for existence and correctness of the format (binary)

Test cases

  1. Transform works correctly with set ignore_flag_column -- it should leave the holidays intersecting with outliers
  2. Calling fit with absence/incorrect formatted holidays_flag_column raises the corresponding error

Additional context

@Mr-Geekman Mr-Geekman added DKO enhancement New feature or request priority/medium Medium priority task labels Aug 14, 2023
@Mr-Geekman Mr-Geekman moved this to Todo in etna board Aug 15, 2023
@d-a-bunin d-a-bunin moved this from Todo to Hold in etna board Mar 26, 2024
@d-a-bunin d-a-bunin removed the DKO label Mar 26, 2024
@brsnw250 brsnw250 moved this from Hold to Todo in etna board Mar 28, 2024
@brsnw250 brsnw250 moved this from Todo to In Progress in etna board Mar 28, 2024
@Polzovat123 Polzovat123 moved this from In Progress to In Review in etna board Apr 1, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium Medium priority task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants