Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach OutliersTransform to ignore holidays #291

Merged
merged 32 commits into from
Apr 9, 2024
Merged

Conversation

Polzovat123
Copy link
Collaborator

@Polzovat123 Polzovat123 commented Apr 1, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  1. Add parameters ignore_flag_column: Optional[str] = None -- if set, then it should be column with binary flag of holiday (which might be created from the HolidaysTransform)
  2. Update the transform method: now it should ignore the outliers on dates with true values in ignore_flag_column.
  3. Update the fit method: now it should check the ignore_flag_column for existence and correctness of the format (binary)

Need to be added:

Need to be fixed:

Closing issues

closes #22
closes #293

@Polzovat123 Polzovat123 added the enhancement New feature or request label Apr 1, 2024
@Polzovat123 Polzovat123 requested a review from brsnw250 April 1, 2024 06:03
Copy link

github-actions bot commented Apr 1, 2024

🚀 Deployed on https://deploy-preview-291--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 1, 2024 06:08 Inactive
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (7dc5665) to head (6c83b12).
Report is 1 commits behind head on master.

❗ Current head 6c83b12 differs from pull request most recent head 95e5129. Consider uploading reports for the commit 95e5129 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #291       +/-   ##
===========================================
+ Coverage   10.46%   90.17%   +79.70%     
===========================================
  Files         203      203               
  Lines       14318    14334       +16     
===========================================
+ Hits         1498    12925    +11427     
+ Misses      12820     1409    -11411     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 06:35 Inactive
@brsnw250 brsnw250 assigned Polzovat123 and unassigned brsnw250 Apr 2, 2024
etna/transforms/outliers/base.py Outdated Show resolved Hide resolved
etna/transforms/outliers/base.py Outdated Show resolved Hide resolved
etna/transforms/outliers/base.py Outdated Show resolved Hide resolved
etna/transforms/outliers/base.py Outdated Show resolved Hide resolved
etna/transforms/outliers/point_outliers.py Outdated Show resolved Hide resolved
@brsnw250
Copy link
Collaborator

brsnw250 commented Apr 2, 2024

We have PR description template, please, follow it

@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 04:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 05:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 07:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 09:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 09:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 10:52 Inactive
@Polzovat123 Polzovat123 requested a review from brsnw250 April 4, 2024 06:50
CHANGELOG.md Show resolved Hide resolved
etna/analysis/outliers/prediction_interval_outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers/base.py Outdated Show resolved Hide resolved
etna/transforms/outliers/base.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request April 4, 2024 08:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 4, 2024 09:21 Inactive
@Polzovat123 Polzovat123 requested a review from brsnw250 April 5, 2024 03:54
@github-actions github-actions bot temporarily deployed to pull request April 5, 2024 09:37 Inactive
@Polzovat123 Polzovat123 requested a review from brsnw250 April 5, 2024 09:41
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request April 5, 2024 13:40 Inactive
@Polzovat123 Polzovat123 requested a review from brsnw250 April 5, 2024 14:02
@github-actions github-actions bot temporarily deployed to pull request April 5, 2024 14:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 8, 2024 07:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 8, 2024 16:51 Inactive
@Polzovat123 Polzovat123 merged commit ba63d88 into master Apr 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants