-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make SVG textures usable as textures directly #4
base: main
Are you sure you want to change the base?
Conversation
4301d68
to
a3d7307
Compare
a3d7307
to
4a49688
Compare
This is super fun! I was actually thinking myself to do something like this, but felt the task is very daunting. I'll review & merge it upstream if all good. May I ask your use case? |
I'll test your PR on android/ios/mac/win & then merge it. Important to also test Shipping & Packaged builds, since they behave differently & it took me a while to properly get a packaged build to work the first time round. |
Yeah OK perfect, I didn't used android/ios/mac/linux at all during dev, only windows. But if it works everywhere, I'm the happiest guy on earth :) The most probable thing I see is that some methods might need to be proxied too; I did not proxy everything, just the minimum to work in my use case. Oh and there is still a minor issue: it seems that the texture needs to be re-baked every time at runtime in standalone builds. It works, but cause a bit of lagging when the texture loads the 1st time. I don't understand a thing about mips & stuff, but I feel like some baked data is not serialized/deserialized correctly, and is thus recomputed at runtime. |
Yeah, we should fix that. I also had serialization issues at first, so I
might be able to find the problem.
But yea, before merging I want it to work cross platform & properly
serialize/deserialize without runtime cost. I'm a bit busy for about 1
week, so if you get to it before then, it would be super nice.
Otherwise, I'll take a look in about a week.
…On Sun, 8 Sept 2024 at 19:21, Gerkin ***@***.***> wrote:
Yeah OK perfect, I didn't used android/ios/mac/linux at all during dev,
only windows. But if it works everywhere, I'm the happiest guy on earth :)
The most probable thing I see is that some methods might need to be
proxied too; I did not proxy everything, just the minimum to work in my use
case.
Oh and there is still a minor issue: it seems that the texture needs to be
re-baked every time at runtime in standalone builds. It works, but cause a
bit of lagging when the texture loads the 1st time. I don't understand a
thing about mips & stuff, but I feel like some baked data is not
serialized/deserialized correctly, and is thus recomputed at runtime.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPBB6H5OTYOIMHBDVFD6WTZVR2RBAVCNFSM6AAAAABNSV7GUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWG42DGMBXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This PR makes USvgTexture inherit from texture, with all required methods proxied to the underlying
Texture
instance property.I tested it with UI widgets, and it works well.