Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Hi #1

wants to merge 5 commits into from

Conversation

TheFrenchLeaf
Copy link

Hi Engin,
It's Pierre ([email protected])

I purpose you some code change in libDaisy

First a code simplification by avoiding code duplicates for the convolution

Add CMakeLists build rules to compile daisy as a library easily through CMake.

It could be fun now to see if we could put some Openmp things to make daisy multicore able ;-)

Regards,
Pierre

Hi hope everything is fine with your new projects.

…avoids code duplicates.

Add CMakeLists build rules to compile daisy as a library.
@etola
Copy link
Owner

etola commented Apr 12, 2012

did you make any speed experiments after changing the convolution code ? I don't like to have 'too generic' code for optimized operations. daisy depends hugely on convolutions and I expect them to be float since the descriptor is computed in float. For example I do vertical convolutions for multiple columns in a go to avoid cache misses and if someone passes double along the way then those optimized convolution operations will slow down...

also, for your multi core remarks... there are already openmp preprocessor instructions in the code. if it doesn't work for you, you need to enable them in the makefile.

I'll check cmakelist and incorporate it.

pmoulon added 3 commits April 13, 2012 15:19
Add compilation of the main.cpp file. Support only grayscale ppm files natively.
@TheFrenchLeaf
Copy link
Author

Hi Engin,

I have fix the OpenMP auto detection in the Cmake compilation rules and add the compilation of the main.cpp file.

The compiler do the job to create the good function in regards of the template instantiation in the code.
You could check if performance change occur for you on linux. On windows I do not observe variation in the timings.

Regards.

Later I could manage the jpeg and png detection and linking under linux withing the cmakeFile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants