-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new benchmark #294
Draft
olejandro
wants to merge
2
commits into
main
Choose a base branch
from
olex/add-a-benchmark
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add a new benchmark #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@siddharth-krishna is the CI failing related to changes in #293 ? |
siddharth-krishna
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it looks like the tool errored on the new benchmark (the error is hidden somewhere in the middle of the log because we run benchmarks in parallel):
Traceback (most recent call last):
File "/home/runner/work/xl2times/xl2times/xl2times/.venv/bin/xl2times", line 8, in <module>
sys.exit(main())
^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/__main__.py", line 606, in main
run(args)
File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/__main__.py", line 520, in run
tables = convert_xl_to_times(
^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/__main__.py", line 171, in convert_xl_to_times
output = transform(config, input, model)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/transforms.py", line 1592, in fill_in_missing_pcgs
df["primarycg"] = df.apply(expand_pcg_from_suffix, axis=1)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/frame.py", line 10374, in apply
return op.apply().__finalize__(self, method="apply")
^^^^^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/apply.py", line 916, in apply
return self.apply_standard()
^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/apply.py", line 1063, in apply_standard
results, res_index = self.apply_series_generator()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/apply.py", line 1081, in apply_series_generator
results[i] = self.func(v, *self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/transforms.py", line 1581, in expand_pcg_from_suffix
return df["process"] + "_" + df["primarycg"]
~~~~~~~~~~~~~~^~~~~
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
(__main__:MainThread:pid-5927 "/home/runner/work/xl2times/xl2times/xl2times/utils/run_benchmarks.py:251")
2025-01-20 18:02:14.323 | ERROR : tool failed on DemoS_special-t1 (__main__:MainThread:pid-5927 "/home/runner/work/xl2times/xl2times/xl2times/utils/run_benchmarks.py:252")
Thanks for finding it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.