Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new benchmark #294

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add a new benchmark #294

wants to merge 2 commits into from

Conversation

olejandro
Copy link
Member

No description provided.

@olejandro
Copy link
Member Author

@siddharth-krishna is the CI failing related to changes in #293 ?

Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it looks like the tool errored on the new benchmark (the error is hidden somewhere in the middle of the log because we run benchmarks in parallel):

Traceback (most recent call last):
  File "/home/runner/work/xl2times/xl2times/xl2times/.venv/bin/xl2times", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/__main__.py", line 606, in main
    run(args)
  File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/__main__.py", line 520, in run
    tables = convert_xl_to_times(
             ^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/__main__.py", line 171, in convert_xl_to_times
    output = transform(config, input, model)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/transforms.py", line 1592, in fill_in_missing_pcgs
    df["primarycg"] = df.apply(expand_pcg_from_suffix, axis=1)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/frame.py", line 10374, in apply
    return op.apply().__finalize__(self, method="apply")
           ^^^^^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/apply.py", line 916, in apply
    return self.apply_standard()
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/apply.py", line 1063, in apply_standard
    results, res_index = self.apply_series_generator()
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/.venv/lib/python3.11/site-packages/pandas/core/apply.py", line 1081, in apply_series_generator
    results[i] = self.func(v, *self.args, **self.kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/xl2times/xl2times/xl2times/xl2times/transforms.py", line 1581, in expand_pcg_from_suffix
    return df["process"] + "_" + df["primarycg"]
           ~~~~~~~~~~~~~~^~~~~
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
 (__main__:MainThread:pid-5927 "/home/runner/work/xl2times/xl2times/xl2times/utils/run_benchmarks.py:251")
2025-01-20 18:02:14.323 | ERROR    : tool failed on DemoS_special-t1 (__main__:MainThread:pid-5927 "/home/runner/work/xl2times/xl2times/xl2times/utils/run_benchmarks.py:252")

@olejandro
Copy link
Member Author

Thanks for finding it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants