Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Hugo 0.55 (fixes deprecation warnings) #28

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zor-el
Copy link

@zor-el zor-el commented Jul 25, 2019

Since a recent Hugo update, there have been some deprecation warnings about .URL and .Hugo that they will be removed. Hence this proactive fix that updates the code to use the new API (.Permalink and hugo).

zor-el added 4 commits July 25, 2019 01:03
Page's .Hugo is deprecated and will be removed in a future release.
Use the global hugo function.
Page's .URL is deprecated and will be removed in a future release.
Use .Permalink or .RelPermalink.
trailing spaces, final lf
@zor-el zor-el changed the title Compatibility with Hugo 0.55 (Deprecation Warnings) Compatibility with Hugo 0.55 (fixes deprecation warnings) Jul 25, 2019
@dixonge
Copy link

dixonge commented Jul 25, 2019

FYI, @eueung has not responded to any PR’s in about 18 months (Feb. 2018).

Right now the best step is to incorporate changes into your own fork or local copy

@zor-el
Copy link
Author

zor-el commented Jul 27, 2019

@dixonge thanks, I'm aware of that. Submitting the pull request was simply a matter of good manners. :)

I am very interested in keeping this theme alive and I will be maintaining my fork for sure. I intend to keep it generic (like in not add stuff that is specific to my own needs). In that sense I have already patched my fork with the bug fixes #12 and #27, and I'm happy to accept bug fix pull request or consider generic functional enhancements.

y26805 added a commit to y26805/hugo-casper-two that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants