-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update accounts workflow to use docker hub [FLOW-BE-46] #429
Conversation
WalkthroughThis pull request updates the deployment workflows for Re:Earth Accounts in both development and production environments. The changes focus on renaming and consolidating environment variables used for Docker image management, modifying commands to pull, tag, and push images, and updating deployment commands. In the dev workflow, the image is now pulled from Docker Hub using a nightly build tag, while the production workflow removes legacy variables and streamlines the push and deploy steps to Google Cloud Run. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions (Dev)
participant DockerHub as Docker Hub
participant GHCR as GitHub Container Registry
participant GCP as Google Cloud Platform
GH->>DockerHub: Pull image (IMAGE_NAME: reearth/reearth-accounts-api:nightly)
DockerHub-->>GH: Return image
GH->>GH: Tag image with IMAGE_NAME_GHCR & IMAGE_NAME_GCP
GH->>GHCR: Push image (IMAGE_NAME_GHCR)
GH->>GCP: Push image (IMAGE_NAME_GCP)
GH->>GCP: Deploy to Cloud Run
GCP-->>GH: Deployment status
sequenceDiagram
participant GH as GitHub Actions (Prod)
participant DockerHub as Docker Hub
participant GCP as Google Cloud Platform
GH->>DockerHub: Pull image (using IMAGE_NAME_GHCR)
DockerHub-->>GH: Return image
GH->>GH: Tag image (using IMAGE_NAME_GCP)
GH->>GCP: Push image and deploy to Cloud Run
GCP-->>GH: Deployment status
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The naming of environment variables has been aligned with other workflows.
Summary by CodeRabbit