-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README by adding Coopony's app to the sample project list #38
Conversation
Add Coopony's app to the sample project list. Co-Authored-By: Dohyun Lee <[email protected]> Co-Authored-By: Sujin Kim <[email protected]> Co-Authored-By: SEONG PIL JU <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice demo app 👍
As you said, it would be nice if a README.md file was added to the demo app. 😄
I will do an additional review once the readme work is complete. Please leave a comment after working on the readme :)
@jopopcorn @aiclaudev @sujin9 @JuSeongPil I'm also waiting for your last update(such as a README.md) |
I was responsible for the readme file work, but I couldn't add it because something unexpected happened today :( |
there's no need to apologize! when you finish that, let me know :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aiclaudev
Thank you for adding great README guide for your demo application!
I also checked your pending PR which contains UI test 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again to @jopopcorn @aiclaudev @sujin9 @JuSeongPil
The first thing I want to comment on is that it would be really convenient if I could actually check in via sound communication. If it is continuously developed and launched, I think it will be one of the really big social contribution projects.
OK, When I give you detail review,
- I have already left a review once, but I think you need more review of
README.md
- You did a great job with creating the Issue Template, Github Action, Code Owner, and PR Template!
- Euphony APIs seem to have been used appropriately.
- Efforts to make a good sample app are buried in the code.
That's my review finally :)
Please keep working hard to develop.
Okay, I'll review and complete README.md as soon as possible. |
I updated README.md Before :
After :
I reviewed again and again. but if there's anything to modify, I'll modify it. |
Thanks for super fast review and reflection!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's normal for a conflict to occur, but it's strange that it didn't happen!
It may be necessary to pull the latest pull and reflect the merge.
We haven't completed the README of the Soundless-check-in project yet, but we uploaded the PR first.
If there is a conflict due to the merger of the previous team, I will revise it and upload it again!
Soundless Check-In
This is a check-in application that identifies visitors, especially effective during the COVID-19.
You can check in with sound wave communication instead of QR code.
When the check-in is complete, visitor and store information are stored in the database, along with the check-in time.
For more information, visit the soundless-check-in repository!