Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README by adding Coopony's app to the sample project list #38

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

jopopcorn
Copy link
Member

We haven't completed the README of the Soundless-check-in project yet, but we uploaded the PR first.
If there is a conflict due to the merger of the previous team, I will revise it and upload it again!


Soundless Check-In
This is a check-in application that identifies visitors, especially effective during the COVID-19.
You can check in with sound wave communication instead of QR code.
When the check-in is complete, visitor and store information are stored in the database, along with the check-in time.
For more information, visit the soundless-check-in repository!

Add Coopony's app to the sample project list.

Co-Authored-By: Dohyun Lee <[email protected]>
Co-Authored-By: Sujin Kim <[email protected]>
Co-Authored-By: SEONG PIL JU <[email protected]>
@yeonns yeonns requested review from designe and yeonns August 31, 2021 11:49
Copy link
Member

@yeonns yeonns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice demo app 👍
As you said, it would be nice if a README.md file was added to the demo app. 😄
I will do an additional review once the readme work is complete. Please leave a comment after working on the readme :)

@designe
Copy link
Member

designe commented Aug 31, 2021

@jopopcorn @aiclaudev @sujin9 @JuSeongPil
Thanks for your contribution through sample app development using euphony library!

I'm also waiting for your last update(such as a README.md)
After that, let me leave some detail review :)

@aiclaudev
Copy link
Contributor

I was responsible for the readme file work, but I couldn't add it because something unexpected happened today :(
I apologize. I'll add it quickly !

@designe
Copy link
Member

designe commented Aug 31, 2021

I was responsible for the readme file work, but I couldn't add it because something unexpected happened today :(
I apologize. I'll add it quickly !

there's no need to apologize!
Rather, thank you for your contribution :)

when you finish that, let me know :)

@aiclaudev
Copy link
Contributor

aiclaudev commented Aug 31, 2021

@designe
I completed README.md and merge to our repository. Check please :)

Copy link
Member

@yeonns yeonns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aiclaudev
Thank you for adding great README guide for your demo application!
I also checked your pending PR which contains UI test 👍

Copy link
Member

@designe designe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again to @jopopcorn @aiclaudev @sujin9 @JuSeongPil

The first thing I want to comment on is that it would be really convenient if I could actually check in via sound communication. If it is continuously developed and launched, I think it will be one of the really big social contribution projects.

OK, When I give you detail review,

  1. I have already left a review once, but I think you need more review of README.md
  2. You did a great job with creating the Issue Template, Github Action, Code Owner, and PR Template!
  3. Euphony APIs seem to have been used appropriately.
  4. Efforts to make a good sample app are buried in the code.

That's my review finally :)
Please keep working hard to develop.

@aiclaudev
Copy link
Contributor

Thanks again to @jopopcorn @aiclaudev @sujin9 @JuSeongPil

The first thing I want to comment on is that it would be really convenient if I could actually check in via sound communication. If it is continuously developed and launched, I think it will be one of the really big social contribution projects.

OK, When I give you detail review,

  1. I have already left a review once, but I think you need more review of README.md
  2. You did a great job with creating the Issue Template, Github Action, Code Owner, and PR Template!
  3. Euphony APIs seem to have been used appropriately.
  4. Efforts to make a good sample app are buried in the code.

That's my review finally :)
Please keep working hard to develop.

Okay, I'll review and complete README.md as soon as possible.

@aiclaudev
Copy link
Contributor

aiclaudev commented Sep 1, 2021

I updated README.md
and, related issue is here.

Before :

But, This application has no such inconvenience as using sound wave communication.
If you press the 'GET INFO !', you can receive visitors' information.

After :

Because this application is user-friendly and use sound-communication, there is no inconvenience like above !
If you press the 'GET INFO!', this application will be state that can recognize visitor's information.

I reviewed again and again. but if there's anything to modify, I'll modify it.
Thanks a lot :)

@designe
Copy link
Member

designe commented Sep 1, 2021

I updated README.md
and, related issue is here.

Before :

But, This application has no such inconvenience as using sound wave communication.
If you press the 'GET INFO !', you can receive visitors' information.

After :

Because this application is user-friendly and use sound-communication, there is no inconvenience like above !
If you press the 'GET INFO!', this application will be state that can recognize visitor's information.

I reviewed again and again. but if there's anything to modify, I'll modify it.
Thanks a lot :)

Thanks for super fast review and reflection!!

Copy link
Member

@designe designe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's normal for a conflict to occur, but it's strange that it didn't happen!
It may be necessary to pull the latest pull and reflect the merge.

README.md Outdated Show resolved Hide resolved
@designe designe merged commit 9a72b75 into euphony-io:master Sep 1, 2021
@designe designe added documentation documentation enhancement Sample Proposal Made by Euphony Library labels Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation enhancement Sample Proposal Made by Euphony Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants