Fix notice display #100
Open
Fix notice display #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome and (starting with version 52) Firefox both push the absolutely positioned .notice-stack upwards to the top of the page. A zero height on the element instead of that leads to the same appearance of the notices hovering over the scrollbar as observed previously without the repositioning.
|
Yes, the issue ID is indeed greater than the pull request ID. No glitch in the Matrix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome and (starting with version 52) Firefox both push the absolutely positioned
.notice-stackupwards to the top of the page. A zero height on the element instead of that leads to the same appearance of the notices (which now overflow their container) hovering over the scrollbar as observed previously without the repositioning.Fixes #101.