chore: add compatibility with tombstone records (#2541)

showing the illustrated 404 error
europeana · Feb 10, 2025 · b09e5e2 · b09e5e2
1 parent b40f325
commit b09e5e2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/portal/src/pages/item/_.vue b/packages/portal/src/pages/item/_.vue
@@ -382,6 +382,10 @@
           if (errorResponse?.status === 502 && errorResponse?.data?.code === '502-TS' && !this.fromTranslationError) {
             this.fromTranslationError = true;
             data = await this.$apis.record.get(this.identifier);
+          } else if (error.statusCode === 410) {
+            // TODO: temporary workaround to handle tombstone records like 404s
+            //       til tombstone page implemented
+            return this.$error({ ...error, statusCode: 404, message: 'Not Found' }, { scope: 'item' });
           } else {
             return this.$error(error, { scope: 'item' });
           }

diff --git a/packages/portal/tests/unit/pages/item/_.spec.js b/packages/portal/tests/unit/pages/item/_.spec.js
@@ -2,6 +2,7 @@ import { createLocalVue } from '@vue/test-utils';
 import { shallowMountNuxt } from '../../utils';
 import BootstrapVue from 'bootstrap-vue';
 import sinon from 'sinon';
+import createHttpError from 'http-errors';
 
 import page from '@/pages/item/_';
 import useDeBias from '@/composables/deBias.js';
@@ -523,6 +524,17 @@ describe('pages/item/_.vue', () => {
 
         expect(wrapper.vm.$error.called).toBe(true);
       });
+
+      describe('when error is 410 Gone (tombstone)', () => {
+        it('(temporarily) calls $error as with 404 Not Found', async() => {
+          const wrapper = factory();
+          wrapper.vm.$apis.record.get = sinon.stub().throws(() => createHttpError(410));
+
+          await wrapper.vm.fetch();
+
+          expect(wrapper.vm.$error.calledWith(sinon.match.has('statusCode', 404))).toBe(true);
+        });
+      });
     });
 
     describe('on client-side request', () => {