Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for both LegacyChatService and TextChatService in regards to player targetted binds #322

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Krcnos
Copy link
Contributor

@Krcnos Krcnos commented Mar 4, 2024

This pull request adds support for both LegacyChatService and TextChatService in regards to player targetted binds. By default newly created games utilise TextChatService now and having this on doesn't support the .Chatted player event so the bind functionality therefore needs to be updated to dynamically support both.

Declarations:

  • I declare that this contribution was created in whole or in part by me.
  • I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
  • I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

Copy link
Collaborator

@autonordev autonordev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the Stylua formatter on these changes, as stylua violations will cause CI to fail

@autonordev
Copy link
Collaborator

Otherwise these changes look good to me. I'm happy to merge if they pass manual tests (by wil) and CI.

@Krcnos
Copy link
Contributor Author

Krcnos commented Mar 6, 2024

Installed stylua and committed changes it made, hopefully that passes

@autonordev autonordev merged commit 232064c into evaera:master Mar 7, 2024
1 check passed
@autonordev
Copy link
Collaborator

Thanks for the contribution! @Krcnos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants