Fix issues with the generateTypeLinks function
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* External Type Links are now properly added from Members of Classes * Fixed Class Type Links being added to the `classNames` object instead of the `classTypeNames` object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an oversight with External Types defined in function, type, or property doc comments not being linked on the generated website. The original implementation only pulled external types from classes, not members of classes.
Another likely oversight, where both constants
externalTypesandclassTypeNameswould be undefined, but were expected to be individual objects when constructing thetypeLinksobject, has been resolved with a small refactor.