Improve dispatch mechanism #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the automatic parsing of string typed arguments in multi-argument operations, and leaves only the division of a dimensional quantity by a string that parses to the same dimension, so that the notation can be used to unwrap a quantity and scale it to the desired reference.
This patch replaces the _dispatch method by a table based dispatch machanism, for faster lookups and better defined work packages.
This patch removes the ability to multiply or divide a Dimension by a non-Dimension, which is no longer in use since the introduction of the new dispatch mechanism.
This patch removes the reference_quantity attribute of the Dimension meta-class, the purpose of which is to be replaced by a new dispatch mechanism for third party function calls.
This patch adds support for nutils functions via the new __nutils_function__ dispatch mechanism.
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 94.60% 93.54% -1.06%
==========================================
Files 2 2
Lines 500 527 +27
==========================================
+ Hits 473 493 +20
- Misses 27 34 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.