Skip to content

Commit

Permalink
bump minimal numpy version to 1.17
Browse files Browse the repository at this point in the history
This patch bumps the minimum required Numpy version from 1.16 to 1.17, which is
the first version that enables Numpy's array function protocol by default.
While Numpy 1.16 does support this protocol, it requires the
NUMPY_EXPERIMENTAL_ARRAY_FUNCTION environment to be set, which is more effort
that it is worth to support an old version.

Additionally, this patch changes the testing matrix by lowering the Python
version for which Numpy 1.17 is tested from 3.8 to 3.6, which is the highest
version for which pypi hosts precompiled wheels.
  • Loading branch information
gertjanvanzwieten committed Nov 5, 2021
1 parent 90b081f commit 3d5d5a1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
# nprocs
- {os: ubuntu-latest , python-version: 3.9, matrix-backend: numpy, nprocs: 2, numpy-version: latest}
# numpy-version
- {os: ubuntu-latest , python-version: 3.8, matrix-backend: numpy, nprocs: 1, numpy-version: 1.16 }
- {os: ubuntu-latest , python-version: 3.6, matrix-backend: numpy, nprocs: 1, numpy-version: 1.17 }
# tensorial
- {os: ubuntu-latest , python-version: 3.9, matrix-backend: numpy, nprocs: 1, numpy-version: latest, tensorial: test}
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
long_description = long_description,
license = 'MIT',
python_requires = '>=3.5',
install_requires = ['numpy>=1.16', 'treelog>=1.0b5', 'stringly'],
install_requires = ['numpy>=1.17', 'treelog>=1.0b5', 'stringly'],
extras_require = dict(
docs=['Sphinx>=1.6','scipy>=0.13','matplotlib>=1.3'],
matrix_scipy=['scipy>=0.13'],
Expand Down

0 comments on commit 3d5d5a1

Please sign in to comment.