eliminate and remove EvaluableConstant #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments passed to the convenience class `function.Custom` are lowered to `evaluable.Array` if the argument is an instance of `function.Array` and to `EvaluableConstant` if something else. This patch eliminates the use of `EvaluableConstant` by passing the non-`function.Array` arguments to `_CustomEvaluable` as is.
joostvanzwieten
force-pushed
the
drop-evaluable-constant
branch
from
9bd4f66 to
4b73a78
Compare
8 tasks
gertjanvanzwieten
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make the
evaluablemodule array-only (#738), this PR eliminates and removes theevaluable.EvaluableConstantclass.