support locate on tensorial topologies #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch add support for locate on tensorial topologies, by moving the locate implementation from TransformChainsTopology to the Topology base class. This is mode possible by adding a new method _lower_args, as well as an implementation of _Mul._sample.
gertjanvanzwieten
force-pushed
the
locate
branch
from
17b526a to
4fed5cc
Compare
joostvanzwieten
approved these changes
Feb 9, 2024
gertjanvanzwieten
added a commit
that referenced
this pull request
Feb 9, 2024
gertjanvanzwieten
added a commit
that referenced
this pull request
Feb 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add support for locate on tensorial topologies, by moving the locate implementation from TransformChainsTopology to the Topology base class. This is mode possible by adding a new method _lower_args, as well as an implementation of _Mul._sample. The Sample.zip method received a new optional ndims argument to facilitate zipping of samples with varying dimensions.