replace const Arrays with Constants in optimize #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To speed-up repeated evaluation of the same `Evaluable`, this patch introduces `Evaluable._deep_flatten_constants`, which replaces constant `Array`s with `Constant`s, excluding the no-op arrays `Transpose` and `InsertAxis`, and includes this in `optimized_for_numpy`.
This patch removes the special-cased optimization for transforming constant `Pointwise`s to `Constant`s in favour of the just introduced, generic `_deep_flatten_constants`.
joostvanzwieten
force-pushed
the
flatten-constants
branch
from
93fc03c to
733bd99
Compare
gertjanvanzwieten
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed-up repeated evaluation of the same
Evaluable, this PR introducesEvaluable._deep_flatten_constants, which replaces constantArrays withConstants, excluding the no-op arraysTransposeandInsertAxis, and includes this inoptimized_for_numpy.