implement intbounds for FloorDivide #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the lower bound is `inf`, no integer number will satisfy the lower bound, which implies the array must have size zero, in which case the bounds are useless. This patch disallows `inf` lower bounds and `-inf` upper bounds.
`evaluable.divmod(x, y)` returns `x - (x // y) * y` as remainder. There are
three issues with this:
* When calling `evaluable.div`, `evaluable.mod` *and* `evaluable.divmod`
we're doing extra work. This can be solved by changing the implementation
of `evaluable.mod`, but:
* It appears to be cheaper to compute the modulo using `numpy.mod` on x86
since the remainder is a byproduct of the
[div](https://www.felixcloutier.com/x86/div) instruction.
* `evaluable.Mod` (note the capital) has an implementation for the integer
bounds and the remainder of `evaluable.divmod` has not.
This patch changes the implementation of the remainder of `evaluable.divmod` to
`evaluable.Mod`.
joostvanzwieten
force-pushed
the
floor-divide-intbounds
branch
from
58bca88 to
565b2d0
Compare
gertjanvanzwieten
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.