make graphviz svg interactive #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostvanzwieten
requested changes
Feb 28, 2024
|
Very nice! |
What about the scale modification? (2nd commit) |
Fine by me. |
gertjanvanzwieten
force-pushed
the
graphviz
branch
from
33b01b4 to
11f4d0c
Compare
Actually in the new version it's less ugly. Without onload I can insert the javascript near the bottom which is easier, and separate the scaling of width and height entirely (no longer confined to svg attributes, but it's probably ok) (edit: restored confinement to svg attributes) |
gertjanvanzwieten
force-pushed
the
graphviz
branch
2 times, most recently
from
308a004 to
659a660
Compare
This patch inserts a javascript snippet into generated svg graphs to make nodes and edges highlightable in capable viewers (such as a web browser).
This patch modifies the width and height parameters of the graphviz generated svg image in order to scale it down to 2/3 the original size. This avoids having to scale the image via the browser which may affect other tabs as well. Sadly it does not seem possible to instruct the dot executable to generate an image at the desired scale directly. The regular expression that is used instead is fairly sensitive to the generated xml, but that is acceptable given that the only risk is to leave the svg at its original scale.
gertjanvanzwieten
force-pushed
the
graphviz
branch
from
659a660 to
ad33d53
Compare
joostvanzwieten
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.