Close <li> tags #160
Close <li> tags #160
Conversation
Added option for target="_blank"
Added option for target="_blank"
Added target="_blank" option. Add HTML code for blank lines.
Typo.
Fixed typo
Added center-alignment for HTML.
Cleanup
Moved maybeCloseAttrs to the beginning of handleText to make sure that any attribute tags are closed even when there is no additional whitespace between different format types. Moved superscript and subscript attribute changes (push) to the rest of the attribute changes to avoid opening a new tag before closing the old ones.
Minor version updates and redundant comment.
Update dev branch to match current main branch
…nk" option to open links in a new tab (evbacher#155) * Update sidebar.html Added option for target="_blank" * Update html.gs Added option for target="_blank" * Update gdc.gs Added target="_blank" option. Add HTML code for blank lines. * Update gdc.gs * Update gdc.gs Typo. * Update sidebar.html Fixed typo * Update gdc.gs Added center-alignment for HTML. * Update gdc.gs Cleanup * Update gdc.gs Moved maybeCloseAttrs to the beginning of handleText to make sure that any attribute tags are closed even when there is no additional whitespace between different format types. Moved superscript and subscript attribute changes (push) to the rest of the attribute changes to avoid opening a new tag before closing the old ones. * Update gdc.gs Minor version updates and redundant comment. * Update gdc.gs
Changed how center/right align were handled in HTML.
Changed how center/right align were handled in HMTL.
Added support for Markdown Checkboxes
Testing out a way of closing all list items in HTML. This is breaking nesting lists, but maybe they never worked.
Update html.gs
Changed how closing listitems and lists is handled. All listItems should close just before opening a new one. Lists should close when necessary.
Changed how closing listitems and lists is handled. All listItems should close just before opening a new one. Lists should close when necessary.
|
Sorry. I just keep chipping away at this. I think I have complex lists working now in HTML conversion. If you have a way to streamline some of the conditions or track nesting level, please update. |
|
Some of your changes look to be excellent, but for some reason, your add-on is mangling the Emerson stuff you added at the end of your copy of the verification doc. There are so many changes going on right now (both yours and some work I'm doing), it's hard to keep track. My Git/GitHub skills are marginal at best, so please hold off until I have a chance to catch up a bit. I may need to bring in some of these changes manually (and gradually). But I want to make sure you get a pull request and contributor credit, because these are some really good changes. Thanks for your patience! |
|
I appreciate you taking the time to look at it. I'm not a github wiz either, so there probably is a better way of going about this. I think I've gotten it to where I would like it to be for my upload purposes, so I shouldn't need to tweak it until you catch up unless there is a bug I created. (I do have some ideas to simplify the code at some places). The document shared with you is now a hard fork with a specific image upload feature for my company. That document is used to push out a local version of the add-on for my team. I've shared with you the new document that more closely corresponds to the commits for the main branch. Let me know if there is anything else I can do that would be helpful for you sorting through and tracking commits. Would it be better for me to identify which commits are for which changes? |
I believe edit properly closes the <li> tags without breaking the list organization. At least from the test in the W3schools tryit editor, the HTML output looked the same.
This should address bugs #3 , #34 , and #47
This also adds checkbox functionality for Markdown.